@sgiehl opened this Pull Request on May 18th 2021 Member

Description:

Seems Alexa has changes the site were we fetch the rank from. It now contains a lot javascript which can't be parsed correctly, resulting in a lot warnings. Added libxml_use_internal_errors(true) to ignore them.
Also the markup changed so I tried to adjust the xpath handing to fetch the correct value again.

fixes https://github.com/matomo-org/matomo/issues/17578

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on May 18th 2021 Member

Doesn't seem to work for me. If I try to get the stats for google.com, the rank is not parsed (the xpath fails, and $value is set to NULL).

@sgiehl commented on May 19th 2021 Member

Oh. Seems I accidentally committed a ! in the if condition that shouldn't have been there... Should work now.

This Pull Request was closed on May 19th 2021
Powered by GitHub Issue Mirror