Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore performance metrics that are obviously too high #17574

Merged
merged 3 commits into from May 21, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 17, 2021

Description:

Added a check for one hour for now. Might be even fine to check for 10 minutes or so, as no website performance metric should contain a number higher that this.

refs #17035

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 17, 2021
@sgiehl sgiehl modified the milestones: 4.4.0, 4.3.1 May 18, 2021
@tsteur tsteur merged commit e1d85b5 into 4.x-dev May 21, 2021
@tsteur tsteur deleted the invalidperformancemetrics branch May 21, 2021 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants