@sgiehl opened this Pull Request on May 17th 2021 Member

Description:

When geolocation is configured and a provider other than the default is used, the diagnostic might currently only show a green tick. For support and debugging purpose it might be useful to directly know which provider is currently used and which location properties are available. This might help us to better answer support requests or issues on github where people are having problems with geolocation and post the diagnostic result.

image

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on May 18th 2021
Powered by GitHub Issue Mirror