Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves Geolocation diagnostics #17573

Merged
merged 1 commit into from May 18, 2021
Merged

Improves Geolocation diagnostics #17573

merged 1 commit into from May 18, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 17, 2021

Description:

When geolocation is configured and a provider other than the default is used, the diagnostic might currently only show a green tick. For support and debugging purpose it might be useful to directly know which provider is currently used and which location properties are available. This might help us to better answer support requests or issues on github where people are having problems with geolocation and post the diagnostic result.

image

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label May 17, 2021
@sgiehl sgiehl added this to the 4.4.0 milestone May 17, 2021
diosmosis
diosmosis approved these changes May 17, 2021
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sgiehl sgiehl merged commit 9c128dd into 4.x-dev May 18, 2021
@sgiehl sgiehl deleted the geoipdiagnostics branch May 18, 2021 06:49
@mattab mattab modified the milestones: 4.5.0, 4.4.0 May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @diosmosis @mattab