Make sure summary row subtables are included in the serialized representaion of a datatable tree. #17569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…entaion of a datatable tree.
flamisz
previously approved these changes
May 16, 2021
|
As I see in the tests there is an error. |
|
The test failure seems unrelated. This is for an L3 issue in JIRA so the description of the bug it fixes is hidden, and it would be pretty hard to manually test. You'd have to set the ranking query INI config really low, track a ton of data w/, say, events that creates top level reports w/ subtables (including in the Others row), then archive w/ ranking query. I couldn't actually get that to work, so just debugged on prod. |
flamisz
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If a summary row has a subtable, it will not be serialized because we go over the
$rowsproperty, but the summary row is held in a different property. Fixed by including it.This was causing the strange "Row with label '%s' (columns = %s) has already a subtable" errors. The summary row subtable couldn't be loaded from the DB, just the ID, so when summing them, we'd trigger this warning.
Review