@diosmosis opened this Pull Request on May 16th 2021 Member

Description:

If a summary row has a subtable, it will not be serialized because we go over the $rows property, but the summary row is held in a different property. Fixed by including it.

This was causing the strange "Row with label '%s' (columns = %s) has already a subtable" errors. The summary row subtable couldn't be loaded from the DB, just the ID, so when summing them, we'd trigger this warning.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@flamisz commented on May 16th 2021 Contributor

As I see in the tests there is an error.

@diosmosis commented on May 16th 2021 Member

The test failure seems unrelated. This is for an L3 issue in JIRA so the description of the bug it fixes is hidden, and it would be pretty hard to manually test. You'd have to set the ranking query INI config really low, track a ton of data w/, say, events that creates top level reports w/ subtables (including in the Others row), then archive w/ ranking query. I couldn't actually get that to work, so just debugged on prod.

This Pull Request was closed on May 17th 2021
Powered by GitHub Issue Mirror