@Findus23 opened this Pull Request on May 16th 2021 Member

fixes #17565

seems like this was changed some time ago (https://github.com/w3c/csswg-drafts/issues/510)

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on May 16th 2021 Member

Is this something other browsers might still implement as none? I'm wondering if we should have both just in case.

@Findus23 commented on May 17th 2021 Member

@diosmosis I was wondering the same thing, but I can't find any information about this. But it seems like none was never in a finished standard, so no browser should have implemented it (at least in theory): https://github.com/w3c/css-validator/issues/231

@sgiehl commented on May 17th 2021 Member

When I add speak: never to an element my Chrome reports it as invalid. The computed styles then show speak: normal.
speak: none would be valid in Chrome.
Firefox actually does not know the property speak and reports all values as invalid.

@Findus23 commented on May 17th 2021 Member

@sgiehl Indeed it seems to be the same for me. I'm not even sure if this is even implemented in a browser and does anything. Using aria-hidden on icons seems to be the better solution for accesibility anyway.

@sgiehl commented on May 18th 2021 Member

So shall we simply close this one? Or should we add both (none and never), so the browser can decide which one to pick?

@github-actions[bot] commented on June 4th 2021 Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @tsteur @sgiehl @diosmosis @flamisz

@Findus23 commented on June 4th 2021 Member

As none is the value chromium suggests and I think everyone else not supporting this at all, the best thing is probably to just close this.

This Pull Request was closed on June 4th 2021
Powered by GitHub Issue Mirror