Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use speak: never #17566

Closed
wants to merge 1 commit into from
Closed

use speak: never #17566

wants to merge 1 commit into from

Conversation

Findus23
Copy link
Member

fixes #17565

seems like this was changed some time ago (https://github.com/w3c/csswg-drafts/issues/510)

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review labels May 16, 2021
@diosmosis
Copy link
Member

Is this something other browsers might still implement as none? I'm wondering if we should have both just in case.

@Findus23
Copy link
Member Author

@diosmosis I was wondering the same thing, but I can't find any information about this. But it seems like none was never in a finished standard, so no browser should have implemented it (at least in theory): https://github.com/w3c/css-validator/issues/231

@sgiehl
Copy link
Member

sgiehl commented May 17, 2021

When I add speak: never to an element my Chrome reports it as invalid. The computed styles then show speak: normal.
speak: none would be valid in Chrome.
Firefox actually does not know the property speak and reports all values as invalid.

@Findus23
Copy link
Member Author

@sgiehl Indeed it seems to be the same for me. I'm not even sure if this is even implemented in a browser and does anything. Using aria-hidden on icons seems to be the better solution for accesibility anyway.

@sgiehl
Copy link
Member

sgiehl commented May 18, 2021

So shall we simply close this one? Or should we add both (none and never), so the browser can decide which one to pick?

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

This issue is in "needs review" but there has been no activity for 7 days. ping @tsteur @sgiehl @diosmosis @flamisz

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jun 4, 2021
@Findus23
Copy link
Member Author

Findus23 commented Jun 4, 2021

As none is the value chromium suggests and I think everyone else not supporting this at all, the best thing is probably to just close this.

@Findus23 Findus23 closed this Jun 4, 2021
@Findus23 Findus23 mentioned this pull request Jun 4, 2021
Closed
@sgiehl sgiehl deleted the speak-never branch April 5, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Stale The label used by the Close Stale Issues action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSS: "speak" property: "none" changed to "never"
3 participants
@Findus23 @diosmosis @sgiehl