Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error while processing "letter-spacing" (old "Waves" library) #17563

Open
math-GH opened this issue May 16, 2021 · 1 comment
Open

Error while processing "letter-spacing" (old "Waves" library) #17563

math-GH opened this issue May 16, 2021 · 1 comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.

Comments

@math-GH
Copy link

math-GH commented May 16, 2021

grafik
link: https://demo.matomo.cloud/index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#?idSite=1&period=day&date=yesterday&segment=&category=Dashboard_Dashboard&subcategory=1

grafik

Expected Behavior

no CSS error

Current Behavior

cannot use letter-spacing property, because of missed unit

Possible Solution

a) update Wave library (used version from 2014: 0.6.0, newest version from 2018: 0.7.6)
b) fix this error with a unit (f.e. "rem")
c) check if this library is still in use and maybe do not use it anymore

Steps to Reproduce (for Bugs)

see above

Your Environment

  • Matomo Version: 2.4.1 (demo.matomo.cloud)
  • Browser: Firefox
  • Operating System: Windows 10
@math-GH math-GH added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 16, 2021
@Findus23 Findus23 added c: Design / UI For issues that impact Matomo's user interface or the design overall. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 16, 2021
@Findus23
Copy link
Member

Hi,

All of this is a part of materialize.css and I think this is the line causing the error:


(the waves thing is just in the same line when minified)

So this is the same as Dogfalo/materialize#6593, Dogfalo/materialize#6018, Dogfalo/materialize#6492

As materialize.css is unmaintained, I doubt this will be fixed, but you could propose a fix to the fork (https://github.com/materializecss/materialize) and once Matomo uses the fork (#16368), this will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall.
Projects
None yet
Development

No branches or pull requests

3 participants