Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace: "more" link does not work #17561

Closed
math-GH opened this issue May 16, 2021 · 7 comments · Fixed by #17570
Closed

Marketplace: "more" link does not work #17561

math-GH opened this issue May 16, 2021 · 7 comments · Fixed by #17570
Assignees
@flamisz
Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Milestone
4.3.0

Comments

@math-GH
Copy link

math-GH commented May 16, 2021

If you click in the marketplace on the "more" link, than nothing happens.

grafik

Expected Behavior

more information will shown

Current Behavior

nothing happend. The hash anchor jumps to the top of page:

module=Marketplace&action=overview&idSite=1&period=range&date=previous30&activated=&mode=admin&type=&show=#

Steps to Reproduce (for Bugs)

open the marketplace page and click on the "more" link on each plugin. See screenshot

Your Environment

  • Matomo Version: 4.2.1
  • PHP Version: 7.4.3
  • Browser: Firefox 88
  • Operating System: Windows 10
@math-GH math-GH added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 16, 2021
@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 16, 2021
@diosmosis
Copy link
Member

@mathContao thanks for the report! Confirmed this is a bug. I also don't see any code related to handling the '.more' link so I don't know exactly what's going on there.

@tsteur tsteur added the Regression Indicates a feature used to work in a certain way but it no longer does even though it should. label May 16, 2021
@tsteur tsteur added this to the 4.3.0 milestone May 16, 2021
@tsteur
Copy link
Member

tsteur commented May 16, 2021

I just checked and it is setting up a click event listener in https://github.com/matomo-org/matomo/blob/4.3.0-rc2/plugins/Marketplace/angularjs/plugins/plugin-name.directive.js#L51 but for some reason the element doesn't trigger the click event by the looks.

@math-GH
Copy link
Author

math-GH commented May 16, 2021

there is no event appended on the link
grafik

@tsteur
Copy link
Member

tsteur commented May 16, 2021

Hey @mathContao it does the onclick handler in the angular directive.

@flamisz flamisz self-assigned this May 16, 2021
@flamisz
Copy link
Contributor

flamisz commented May 16, 2021

The jquery dotdotdot plugin causes this issue. One solution can be if we simply use style="overflow:hidden" on the description. Anyway, when the description too long, we don't show the more link, because dotdotdot plugin cuts that. the only thing that would be different, if it's too long, we won't see the ellipsis (see attached images).
Other solution could be using some css, but that won't work on old browsers. ping @tsteur @diosmosis
Screen Shot 2021-05-17 at 10 17 04 AM
Screen Shot 2021-05-17 at 10 17 08 AM

@tsteur
Copy link
Member

tsteur commented May 16, 2021

Other solution could be using some css, but that won't work on old browsers.

Do you know which browsers it wouldn't work @flamisz ?

@flamisz
Copy link
Contributor

flamisz commented May 16, 2021

On all IE:
Screen Shot 2021-05-17 at 11 12 17 AM

tsteur added a commit that referenced this issue May 17, 2021
@tsteur
Make more link work again in marketplace plugin list
fe9ae11 
fix #17561
@tsteur tsteur mentioned this issue May 17, 2021
Merged
10 tasks
tsteur added a commit that referenced this issue May 17, 2021
@tsteur
Make more link work again in marketplace plugin list (#17570)
b77e5ff 
fix #17561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flamisz flamisz

Labels
Bug For errors / faults / flaws / inconsistencies etc. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

Make more link work again in marketplace plugin list matomo-org/matomo
4 participants
@diosmosis @tsteur @math-GH @flamisz