Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add flex class #17557

Merged
merged 1 commit into from May 14, 2021
Merged

add flex class #17557

merged 1 commit into from May 14, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented May 13, 2021

Description:

Fix the css issue.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz requested a review from diosmosis May 13, 2021 21:12
@diosmosis
Copy link
Member

works for me 👍

@diosmosis diosmosis merged commit e56ff00 into 4.x-dev May 14, 2021
@diosmosis diosmosis deleted the fixperiodselectorcss branch May 14, 2021 00:11
@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels May 15, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@flamisz @diosmosis @sgiehl