Do not send idGoal=0 parameter for goals overview since 0 is for orders #17554
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #17502
In the past the UI controller method that outputted the goals overview used idGoal=0 to signify it was handling the overview. It would not pass that parameter on to the API, since the API treats idGoal=0 as IDGOAL_ORDER.
This means, currently, we are displaying order goal information in place of the goals overview for scheduled reports. To fix this, we can just not send the idGoal to the API.
The tests are failing, most seem like they are expected. The TSV test however changes the name of the report in the output (though this doesn't happen locally for me).
cc @tsteur for prioritization
Review