@diosmosis opened this Pull Request on May 11th 2021 Member

Description:

The one click update feature updates the code, then on the next page view the db upgrade screen is shown. The actions in between these two components use new code, but an old database schema. This PR makes sure we ignore unknown column errors in the bruteforce detection feature if we're in the one click update process.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on May 11th 2021 Member

@flamisz just fyi, so you're aware if you have to touch this code: this is for the oneclickupdate feature which is extremely hard to test locally. The feature downloads a package from builds.matomo.org, unzips it and replaces the current version of matomo with it. To test it locally w/o a build on builds.matomo.org you'd have to use the matomo-package repo to build a package from 4.x-dev code, then create a new release channel to get it from localhost, then initiate the process. Personally, I find using the test on travis to be a lot less trouble.

This Pull Request was closed on May 11th 2021
Powered by GitHub Issue Mirror