Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure login is set for brute force log when 2fa code is invalid #17545

Merged
merged 1 commit into from May 11, 2021
Merged

Ensure login is set for brute force log when 2fa code is invalid #17545

merged 1 commit into from May 11, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 11, 2021

Description:

Follow up to #17503

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 11, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone May 11, 2021
@sgiehl sgiehl requested a review from diosmosis May 11, 2021 12:20
@diosmosis
Copy link
Member

Tested locally, works

@diosmosis diosmosis merged commit 7ded632 into 4.x-dev May 11, 2021
@diosmosis diosmosis deleted the 2fabruteforce branch May 11, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis