Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make SuspiciousLoginAttemptsInLastHourEmail email from DI container #17543

Merged
merged 1 commit into from May 11, 2021
Merged

make SuspiciousLoginAttemptsInLastHourEmail email from DI container #17543

merged 1 commit into from May 11, 2021

Conversation

diosmosis
Copy link
Member

Description:

Forgot I didn't create this email using DI.

Refs #17503

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 11, 2021
@diosmosis diosmosis requested review from sgiehl and flamisz May 11, 2021 01:52
@diosmosis diosmosis added this to the 4.3.0 milestone May 11, 2021
@diosmosis diosmosis merged commit 9722c45 into 4.x-dev May 11, 2021
@diosmosis diosmosis deleted the 17503-tweak branch May 11, 2021 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

@sgiehl sgiehl Awaiting requested review from sgiehl

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @flamisz