@sgiehl opened this Pull Request on May 10th 2021 Member

Description:

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on May 11th 2021 Member

@flamisz Guess that file is actually already very outdated. I've updated it a bit. But guess we don't need to mention the change in this PR. The unserialize/serialize of session data was actually something we added to get notifications working, which is already mentioned...

This Pull Request was closed on May 11th 2021
Powered by GitHub Issue Mirror