Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Common::safe_unserialize for session data #17539

Merged
merged 3 commits into from May 11, 2021
Merged

Use Common::safe_unserialize for session data #17539

merged 3 commits into from May 11, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 10, 2021

Description:

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels May 10, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone May 10, 2021
flamisz
flamisz reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's looking good to me, but should we add this modification into this file?
https://github.com/matomo-org/matomo/blob/4.x-dev/libs/README.md

@sgiehl
Copy link
Member Author

sgiehl commented May 11, 2021

@flamisz Guess that file is actually already very outdated. I've updated it a bit. But guess we don't need to mention the change in this PR. The unserialize/serialize of session data was actually something we added to get notifications working, which is already mentioned...

@diosmosis diosmosis merged commit ba6be40 into 4.x-dev May 11, 2021
@diosmosis diosmosis deleted the sessionunserialize branch May 11, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @flamisz @diosmosis