Add option to skip log purging check when invalidating archives in the rare cases it is needed. #17538
+48
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgiehl
reviewed
May 10, 2021
core/CliMulti/Process.php
Outdated
Comment on lines
300
to
302
| print getmypid() . "\n"; | ||
| print `ps x 2>/dev/null | awk '! /defunct/ {print $1}' 2>/dev/null` . "\n"; | ||
|
|
There was a problem hiding this comment.
No, task switching w/ an L3 issue, will remove
…e rare cases it is needed.
diosmosis
force-pushed
the
allow-invalidate-purged-dates-if-not-day-option
branch
from
4dab289
to
86a2674
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For use in the GoogleAnalyticsImporter, if log purging is enabled, then we'll never be able to invalidate to dates before it. However, the importer can definitely import dates before it and uses archiving to fill up week, month and year periods. The flag would fix this.
Review