Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add new ini config to enable/disable the php profiler feature #17537

Merged
merged 6 commits into from May 11, 2021
Merged

add new ini config to enable/disable the php profiler feature #17537

merged 6 commits into from May 11, 2021

Conversation

diosmosis
Copy link
Member

Description:

It is now required to set enable_php_profiler = 1 in order for the profiler to be enabled.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 10, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone May 10, 2021
flamisz
flamisz reviewed May 10, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it confusing this setting is under [Development] settings group?
How come the js files changed in this PR, but only the minified versions?

@diosmosis
Copy link
Member Author

Isn't it confusing this setting is under [Development] settings group?

Do you have another suggestion?

How come the js files changed in this PR, but only the minified versions?

Committed by accident. If you have plugins enabled that have custom tracker code, the minified code is automatically changed when loading matomo.

@sgiehl
Copy link
Member

sgiehl commented May 10, 2021

Should we maybe add a note to the developer changelog?

@sgiehl sgiehl removed the Needs Review PRs that need a code review label May 10, 2021
@flamisz
Copy link
Contributor

flamisz commented May 10, 2021

Isn't it confusing this setting is under [Development] settings group?

Do you have another suggestion?

We already have some profiler-related settings under [Debug]. Maybe there?

How come the js files changed in this PR, but only the minified versions?

Committed by accident. If you have plugins enabled that have custom tracker code, the minified code is automatically changed when loading matomo.

👍

@diosmosis
Copy link
Member Author

@sgiehl @flamisz applied review feedback

flamisz
flamisz approved these changes May 11, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@diosmosis diosmosis merged commit b58ed3d into 4.x-dev May 11, 2021
@diosmosis diosmosis deleted the xhprof-profile branch May 11, 2021 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@diosmosis @sgiehl @flamisz