@diosmosis opened this Pull Request on May 10th 2021 Member

Description:

It is now required to set enable_php_profiler = 1 in order for the profiler to be enabled.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on May 10th 2021 Member

Isn't it confusing this setting is under [Development] settings group?

Do you have another suggestion?

How come the js files changed in this PR, but only the minified versions?

Committed by accident. If you have plugins enabled that have custom tracker code, the minified code is automatically changed when loading matomo.

@sgiehl commented on May 10th 2021 Member

Should we maybe add a note to the developer changelog?

@flamisz commented on May 10th 2021 Contributor

Isn't it confusing this setting is under [Development] settings group?

Do you have another suggestion?

We already have some profiler-related settings under [Debug]. Maybe there?

How come the js files changed in this PR, but only the minified versions?

Committed by accident. If you have plugins enabled that have custom tracker code, the minified code is automatically changed when loading matomo.

👍

@diosmosis commented on May 11th 2021 Member

@sgiehl @flamisz applied review feedback

This Pull Request was closed on May 11th 2021
Powered by GitHub Issue Mirror