Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow requests to piwik and matomo php again for bots #17536

Merged
merged 4 commits into from May 10, 2021
Merged

Allow requests to piwik and matomo php again for bots #17536

merged 4 commits into from May 10, 2021

Conversation

tsteur
Copy link
Member

@tsteur tsteur commented May 9, 2021 •
edited

Description:

fix #17497

we discussed to remove it again and might need to think of a different solution if it starts causing issues again for Google Ads.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@tsteur tsteur added this to the 4.3.0 milestone May 9, 2021
@tsteur tsteur added the Needs Review PRs that need a code review label May 9, 2021
@tsteur tsteur added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. and removed Needs Review PRs that need a code review labels May 9, 2021
@tsteur tsteur added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels May 9, 2021
flamisz
flamisz approved these changes May 10, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it, probably will work 👍

@tsteur tsteur merged commit 937e666 into 4.x-dev May 10, 2021
@tsteur tsteur deleted the m17497 branch May 10, 2021 02:49
@mattab mattab added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Re-allow tracking bots
3 participants
@tsteur @flamisz @mattab