@diosmosis opened this Pull Request on May 7th 2021 Member

Description:

When invalidating data, we check for dates that are before the configured log data deletion month count, and ignore them. This is a safety mechanism to make sure we do not invalidate day periods that have archive data, but for whom log data was deleted. This safety mechanism, however, breaks the GoogleAnalyticsImporter, when importing data that is before log data deletion threshold.

The importer imports day periods, then invalidates week periods and above to calculate the rest. If the data is before the log deletion threshold, the higher periods are never recomputed.

Fixed in this PR by only applying the check for day periods. If a week period is invalidated and there is no log data, the day periods should used.

TODO: check if week periods will trigger rearchiving of the day if the day is for some reason invalidated.

FYI @tsteur

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on May 10th 2021 Member

closing in favor of a new option

This Pull Request was closed on May 10th 2021
Powered by GitHub Issue Mirror