Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require password confirmation when resetting 2fa #17528

Merged
merged 4 commits into from May 10, 2021
Merged

require password confirmation when resetting 2fa #17528

merged 4 commits into from May 10, 2021

Conversation

diosmosis
Copy link
Member

Description:

As title.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label May 7, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone May 7, 2021
flamisz
flamisz approved these changes May 7, 2021
View reviewed changes
Copy link
Contributor

@flamisz flamisz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried and worked as expected 👍

@diosmosis diosmosis merged commit 07d3399 into 4.x-dev May 10, 2021
@diosmosis diosmosis deleted the password-conf-2fa-reset branch May 10, 2021 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @flamisz