@sgiehl opened this Pull Request on May 5th 2021 Member

Description:

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@flamisz commented on May 5th 2021 Contributor

Hi @sgiehl, how come the composer.json is not updated in this PR? Shouldn't we do that?

@sgiehl commented on May 6th 2021 Member

@flamisz That's only needed when the composer.json actually prevents an update due to the version restriction.

@diosmosis commented on May 6th 2021 Member

@sgiehl in the future, when we run composer update to update dependencies, will we lose this change?

@sgiehl commented on May 6th 2021 Member

no, why should we? I simply ran a composer update phpmailer/phpmailer and added the changes of composer.lock as usual.

This Pull Request was closed on May 6th 2021
Powered by GitHub Issue Mirror