Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates phpmailer/phpmailer to 6.4.1 #17523

Merged
merged 1 commit into from May 6, 2021
Merged

Updates phpmailer/phpmailer to 6.4.1 #17523

merged 1 commit into from May 6, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented May 5, 2021

Description:

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels May 5, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone May 5, 2021
@flamisz
Copy link
Contributor

flamisz commented May 5, 2021

Hi @sgiehl, how come the composer.json is not updated in this PR? Shouldn't we do that?

@sgiehl
Copy link
Member Author

sgiehl commented May 6, 2021

@flamisz That's only needed when the composer.json actually prevents an update due to the version restriction.

@diosmosis
Copy link
Member

@sgiehl in the future, when we run composer update to update dependencies, will we lose this change?

@sgiehl
Copy link
Member Author

sgiehl commented May 6, 2021

no, why should we? I simply ran a composer update phpmailer/phpmailer and added the changes of composer.lock as usual.

@tsteur tsteur merged commit 39361b1 into 4.x-dev May 6, 2021
@tsteur tsteur deleted the updatephpmailer branch May 6, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flamisz flamisz flamisz approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sgiehl @flamisz @diosmosis @tsteur