@tsteur opened this Pull Request on May 4th 2021 Member

Description:

Performance improvement to have one less update on log_visit for existing visits if action dimensions are used: fix https://github.com/matomo-org/matomo/issues/17173

New visit scenario

Before this PR

  • Insert new visit -> so get idVisit
  • Insert log link action -> so we get idlink_va
  • update visit to set value of the created idlink_va on the column last_idlink_va.

After this PR

Same logic as before. We always have to create visit first before creating any log link action.

Existing visit scenario

Before this PR

  • Update visit (we have idvisit already at this stage)
  • Insert log link action -> so we get idlink_va
  • update visit to set value of the created idlink_va on the column last_idlink_va.

After this PR

  • Insert log link action -> so we get idlink_va
  • Update visit including setting the value of the created idlink_va on the column last_idlink_va.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on May 5th 2021
Powered by GitHub Issue Mirror