Allow invalidating empty site #17519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
added
Needs Review
|
Noticed this has other changes in it, will remove them... |
…ut need to be invalidated at week or higher periods)
diosmosis
force-pushed
the
allow-invalidating-empty-site
branch
from
bbbe655
to
6633a57
Compare
|
Updated. |
|
@diosmosis do you remember why it was maybe added in f5e9420#diff-88e28f71aefcd536256f874d55fa5d6eb2783391010861ed67461ea6bbda4ef2R261-R265 ? I suppose this also impacts roll ups. Looks good otherwise |
|
@tsteur it was an optimization. IIRC you suggested it in a review (I can't remember the exact reasoning), then decided it wasn't that important, but I added it anyway because "why not?". (I guess this is "why not" :) ). I guess we could still do the check, though, if we use the event in Loader.php (isSiteUsingTracker or something similar). |
…m instead of assuming 0 visits
|
@tsteur found another regression causing the importer tests to fail, added in the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Some sites can legitimately have 0 visits, like sites imported from google. While debugging the GoogleAnalyticsImporter test failures I noticed nothing was being invalidated because of this check. Removing it in this PR.
Review