Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Matomo shows visits that occured at Midnight (Start of next day) in visits log for previous day #17516

Open
Starker3 opened this issue May 2, 2021 · 1 comment
Open

Matomo shows visits that occured at Midnight (Start of next day) in visits log for previous day #17516

Starker3 opened this issue May 2, 2021 · 1 comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
Backlog (Help wan...

Comments

@Starker3
Copy link
Contributor

Starker3 commented May 2, 2021

Expected Behavior

When viewing the visits log for example for the 7th of February, we would expect that visits that occur at or after midnight (Start of the the next day) to not be show in the visits log.

Current Behavior

Any visits that are recorded at exactly Midnight which is the start of the day for the 8th of February for example are shown in the visits log for the date of the 7th, but is showing the correct date for the next day:
image

Possible Solution

According to the code here:

matomo/plugins/Live/Model.php

Lines 601 to 603 in 2b35b46

if ($dateEnd->isLater(Date::now())) {
// making sure dateEnd is bit higher than start date plus in case a second past by now ...
$dateEnd = $now->addPeriod(1, 'second');

This seems to be intentional but for unknown reasons.

Steps to Reproduce (for Bugs)

  1. View visits log where visits are recorded at exactly midnight for a specific day

Context

Your Environment

  • Matomo Version: 4.2.1
  • PHP Version: 7.4.16
  • Server Operating System: Linux
  • Additionally installed plugins: NA
@Starker3 Starker3 added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label May 2, 2021
@tsteur tsteur added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels May 2, 2021
@tsteur tsteur added this to the Backlog (Help wanted) milestone May 2, 2021
@tsteur
Copy link
Member

tsteur commented May 2, 2021

kind of refs #9053 #11165

Might have been added 10 years ago to fix some timezone issues but it's not 100% clear.

@heurteph-ei heurteph-ei mentioned this issue May 3, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
Backlog (Help wanted)
Development

No branches or pull requests
2 participants
@tsteur @Starker3