Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no links in copy-paste system check #17515

Merged
merged 2 commits into from May 3, 2021
Merged

Conversation

Findus23
Copy link
Member

@Findus23 Findus23 commented May 2, 2021

related to #17421
inspired by https://forum.matomo.org/t/no-website-was-found-in-this-matomo-installation/41659/9?u=lukas

Some error messages in the system check contain <a href="">. In the plaintext/markdown version those are mostly useless and also trigger the forum limit of max two links per new user.

Unless I am missing something, this should easily fix this.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added the Needs Review PRs that need a code review label May 2, 2021
@tsteur
Copy link
Member

tsteur commented May 2, 2021

Works for me. Could maybe still allow some elements (like |striptags('<br><p><strong><code>')) or so? Might not be too important though but could make our life easier to still have some formatting in there.

@Findus23
Copy link
Member Author

Findus23 commented May 3, 2021

@tsteur Makes sense, I updated it.

@tsteur tsteur merged commit 104135a into 4.x-dev May 3, 2021
@tsteur tsteur deleted the no-links-in-copy-system-reports branch May 3, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants