@Findus23 opened this Pull Request on May 2nd 2021 Member

related to #17421
inspired by https://forum.matomo.org/t/no-website-was-found-in-this-matomo-installation/41659/9?u=lukas

Some error messages in the system check contain <a href="">. In the plaintext/markdown version those are mostly useless and also trigger the forum limit of max two links per new user.

Unless I am missing something, this should easily fix this.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@tsteur commented on May 2nd 2021 Member

Works for me. Could maybe still allow some elements (like |striptags('<br><p><strong><code>')) or so? Might not be too important though but could make our life easier to still have some formatting in there.

@Findus23 commented on May 3rd 2021 Member

@tsteur Makes sense, I updated it.

This Pull Request was closed on May 3rd 2021
Powered by GitHub Issue Mirror