Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

piwik.js: refactoring trackGoal, trackPageView, and trackLink #1751

Closed
robocoder opened this issue Oct 3, 2010 · 5 comments
Closed

piwik.js: refactoring trackGoal, trackPageView, and trackLink #1751

robocoder opened this issue Oct 3, 2010 · 5 comments
Assignees
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone

Comments

@robocoder
Copy link
Contributor

trackGoal and trackPageView both send page view and browser settings. Since it's conceivable that both might be called on the same page, we can optimize piwik.js to only send the payload once per page.

Propose: send the payload once for trackPageView(), trackGoal(), and trackLink(), unless setCustomUrl() or setReferrerUrl() are called. As a side effect, this should allow for additional refactoring that reduces the size of piwik.js.

@robocoder
Copy link
Contributor Author

(In [3224]) fixes #1751

@robocoder
Copy link
Contributor Author

(In [3238]) fixes #1751 - always includes page info and browser settings in payload in case of race conditions (erring on the side of caution)

@mattab
Copy link
Member

mattab commented Nov 16, 2010

so nothing really happened in this ticket correct? shall we close it as 'wontfix' ?

@robocoder
Copy link
Contributor Author

there were changes...just not as I originally proposed, ie previously only trackpageview and trackgoal would attach the browser settings payload; now, tracklink does too

and there was refactoring for consistency (thus smaller piwik.js)

@mattab
Copy link
Member

mattab commented Nov 16, 2010

sounds good!

@robocoder robocoder added this to the Piwik 1.1 milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Development

No branches or pull requests

2 participants