@robocoder opened this Issue on October 3rd 2010 Contributor

trackGoal and trackPageView both send page view and browser settings. Since it's conceivable that both might be called on the same page, we can optimize piwik.js to only send the payload once per page.

Propose: send the payload once for trackPageView(), trackGoal(), and trackLink(), unless setCustomUrl() or setReferrerUrl() are called. As a side effect, this should allow for additional refactoring that reduces the size of piwik.js.

@robocoder commented on October 4th 2010 Contributor

(In [3224]) fixes #1751

@robocoder commented on October 7th 2010 Contributor

(In [3238]) fixes #1751 - always includes page info and browser settings in payload in case of race conditions (erring on the side of caution)

@mattab commented on November 16th 2010 Member

so nothing really happened in this ticket correct? shall we close it as 'wontfix' ?

@robocoder commented on November 16th 2010 Contributor

there were changes...just not as I originally proposed, ie previously only trackpageview and trackgoal would attach the browser settings payload; now, tracklink does too

and there was refactoring for consistency (thus smaller piwik.js)

@mattab commented on November 16th 2010 Member

sounds good!

This Issue was closed on November 16th 2010
Powered by GitHub Issue Mirror