@flamisz opened this Pull Request on April 28th 2021 Contributor

Description:

fixes #14977

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@flamisz commented on May 4th 2021 Contributor

Note:
I wanted to show the generated time for the evolution graphs as well. I found one way, but then it modified the API results' JSON (added the generated time as metadata). I tried a couple of ways to solve it (see the commit history), but couldn't find any "clean" way I liked.
I recommend merge it as it is (of course if the PR is ok) and if we want, we can create a new issue for showing the generated time for evolution graphs. I spent too much time on this for now.

Powered by GitHub Issue Mirror