@diosmosis opened this Pull Request on April 26th 2021 Member

Description:

Detects brute force login attempts from different ip addresses, and notifies the user at most once every two weeks that someone is trying to break into their account this way.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on May 7th 2021 Member

This should be ready for review now

@diosmosis commented on May 10th 2021 Member

But made it work in the end, but the sent email wasn't "templated" properly.

Thanks for catching this. Fixed.

@flamisz commented on May 10th 2021 Contributor

But made it work in the end, but the sent email wasn't "templated" properly.

Thanks for catching this. Fixed.

It looks good now 👍

This Pull Request was closed on May 11th 2021
Powered by GitHub Issue Mirror