Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useEventValueAsRevenue still ticked after switching goal type #17500

Closed
Findus23 opened this issue Apr 26, 2021 · 1 comment · Fixed by #21208
Closed

useEventValueAsRevenue still ticked after switching goal type #17500

Findus23 opened this issue Apr 26, 2021 · 1 comment · Fixed by #21208
Assignees
@sgiehl
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Milestone
5.0.0

Comments

@Findus23
Copy link
Member

Findus23 commented Apr 26, 2021 •
edited

reported in https://forum.matomo.org/t/switch-goal-type-after-creation/41593/2

Expected Behavior

One can create a goal with type "send an event" and afterwards switch the type successfully

Current Behavior

  • create a new goal with "send a goal" set
  • tick Use the event value (if it exists) as the goal conversion revenue.
  • save the goal
  • edit the goal
  • change the type to "visit a given URL"
  • notice how the "Use the event value..." UI dissapears, but still seems to be ticked
  • save the goal
  • see 'useEventValueAsRevenue' can only be 1 if the goal matches an event attribute.

Possible Solution

Whenever the UI is hidden, the value should also be set to 0 as 1 doesn't make any sense anymore
@Findus23 Findus23 added Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently. labels Apr 26, 2021
@leobardimpact
Copy link

This bug is still here.

  1. create a goal that has "goal is triggered: manually", set a "goal revenue: 10", save. Then maybe I did something I forgot to create a state of error.
  2. edit the same goal.
  3. I had the gui in a state where
    a. the goal value "10" was set
    b. but also use_event_value was checked.
    c. the div "form-group row matomo-form-field" around the use_event_value was "display:none"
    c. On save, there was an error message 'useEventValueAsRevenue' can only be 1 if the goal matches an event attribute.
  4. my solution was to use Google Chrome dev tools to remove display:none from the div, uncheck the box, and save.

@sgiehl sgiehl mentioned this issue Aug 31, 2023
Merged
11 tasks
@sgiehl sgiehl self-assigned this Aug 31, 2023
@sgiehl sgiehl added this to the 5.0.0 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Usability For issues that let users achieve a defined goal more effectively or efficiently.
Projects
None yet
Milestone
5.0.0
3 participants
@sgiehl @Findus23 @leobardimpact