Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve method to determine date to archive segments from #17492

Merged
merged 2 commits into from Apr 23, 2021
Merged

Improve method to determine date to archive segments from #17492

merged 2 commits into from Apr 23, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 23, 2021

Description:

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Apr 23, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Apr 23, 2021
@sgiehl sgiehl requested a review from diosmosis April 23, 2021 09:12
@diosmosis diosmosis merged commit c29ee95 into 4.x-dev Apr 23, 2021
@diosmosis diosmosis deleted the segmentarchive branch April 23, 2021 15:15
@diosmosis
Copy link
Member

👍

tsteur
tsteur reviewed Apr 26, 2021
View reviewed changes
Copy link
Member

@tsteur tsteur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't this change behaviour should segmentCreatedTime be empty? We would have previously returned null but now we would treat it as beginning_of_time even if eg from creation time is configured? @sgiehl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsteur tsteur tsteur left review comments

@diosmosis diosmosis Awaiting requested review from diosmosis

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @diosmosis @tsteur