@diosmosis opened this Pull Request on April 23rd 2021 Member

### Description:

Adds a new diagnostic that checks that the tmp/ directory is not accessible, and checks that, if present, the .git/ directory is not accessible.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@Findus23 commented on April 23rd 2021 Member

For reference: I also created a similar check in my plugin that also checks for lang/en.json (less severe, but indicates that the htaccess doesn't work), cache/tracker/matomocache_general.php and config/config.ini.php (also showing a warning if it only outputs ;)

https://github.com/Findus23/matomo-DiagnosticsExtended/blob/main/Diagnostic/URLCheck.php

@diosmosis commented on April 24th 2021 Member

@sgiehl updated the PR.

Also added the directories @Findus23 mentioned :+1: .

@diosmosis commented on April 26th 2021 Member

Unfortunately I don't think there's an easy way to implement it so an actual browser separate from the server makes those requests. At least none that I can think of.

This Pull Request was closed on April 26th 2021
Powered by GitHub Issue Mirror