@flamisz opened this Pull Request on April 22nd 2021 Contributor

Description:

If the nonce parameter is valid, ignore it.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@flamisz commented on May 12th 2021 Contributor

Is there anything else to do here @tsteur?

@tsteur commented on May 12th 2021 Member

I haven't tested it but looks good to me @flamisz . We'd only merge it after the 4.3 release though just to make sure we're not breaking anything

This Pull Request was closed on May 26th 2021
Powered by GitHub Issue Mirror