Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new update to make sure deleted segments also have a computed hash. #17485

Merged
merged 2 commits into from Apr 24, 2021

Conversation

diosmosis
Copy link
Member

Description:

Since deleted segments can be referenced in archive purging and possibly elsewhere. Used a new update in case anyone already used the beta and ran the old update.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 22, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Apr 22, 2021
@diosmosis diosmosis merged commit 8880029 into 4.x-dev Apr 24, 2021
@diosmosis diosmosis deleted the segment-hash-update-tweak branch April 24, 2021 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants