Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not parse plugin details with angular in marketplace overlay #17483

Merged
merged 1 commit into from Apr 23, 2021
Merged

Do not parse plugin details with angular in marketplace overlay #17483

merged 1 commit into from Apr 23, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 22, 2021

Description:

As the content should not contain any angular related stuff, we can simply disable parsing for those elements, which should also save some time.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review labels Apr 22, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Apr 22, 2021
@diosmosis diosmosis merged commit 2956038 into 4.x-dev Apr 23, 2021
@diosmosis diosmosis deleted the plugindescription branch April 23, 2021 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis