Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use DbHelper::getTablesInstalled() in integration test setup … #17480

Merged
merged 1 commit into from Apr 22, 2021
Merged

Do not use DbHelper::getTablesInstalled() in integration test setup … #17480

merged 1 commit into from Apr 22, 2021

Conversation

diosmosis
Copy link
Member

Description:

… since it posts event that loads all activated plugins. Locally this speeds tests up by ~12s (all in the test startup phase).

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis
Do not use DbHelper::getTablesInstalled() in integration test setup s…
67c1a36 
…ince it posts event that loads all activated plugins.
@diosmosis diosmosis added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels Apr 21, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Apr 21, 2021
@sgiehl sgiehl added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 22, 2021
@sgiehl sgiehl merged commit 59bc538 into 4.x-dev Apr 22, 2021
@sgiehl sgiehl deleted the integration-test-speedup branch April 22, 2021 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl