@sgiehl opened this Pull Request on April 21st 2021 Member

Description:

Rearchiving segments expects the full segment dataset. Currently when adding / updating a segment only the changed/added data is given to the rearchiving method. This can result in unexpected behavior.

refs L3-63

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
This Pull Request was closed on April 21st 2021
Powered by GitHub Issue Mirror