Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use full segment data to rearchive segment #17478

Merged
merged 2 commits into from Apr 21, 2021
Merged

Use full segment data to rearchive segment #17478

merged 2 commits into from Apr 21, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 21, 2021

Description:

Rearchiving segments expects the full segment dataset. Currently when adding / updating a segment only the changed/added data is given to the rearchiving method. This can result in unexpected behavior.

refs L3-63

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Regression Indicates a feature used to work in a certain way but it no longer does even though it should. labels Apr 21, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Apr 21, 2021
diosmosis
diosmosis approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one test is failing, otherwise looks good

@diosmosis diosmosis merged commit 6d726c8 into 4.x-dev Apr 21, 2021
@diosmosis diosmosis deleted the fixsegmentrearchiving branch April 21, 2021 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis approved these changes

Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Regression Indicates a feature used to work in a certain way but it no longer does even though it should.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis