Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove urlencode for segment definitions #17475

Merged
merged 3 commits into from Apr 21, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Apr 20, 2021

Description:

fixes #17301

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz added this to the 4.3.0 milestone Apr 20, 2021
@flamisz flamisz added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 20, 2021
@flamisz flamisz self-assigned this Apr 20, 2021
@flamisz flamisz marked this pull request as ready for review April 20, 2021 04:11
@flamisz flamisz added the Needs Review PRs that need a code review label Apr 20, 2021
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and tests are passing. But as I'm not that deep into the latest segment changes might be good if @diosmosis or @tsteur might have a quick look as well.

@diosmosis
Copy link
Member

There's an integration test failing now. Will merge once build passes.

@flamisz
Copy link
Contributor Author

flamisz commented Apr 21, 2021

@diosmosis tests are back to green.

@diosmosis diosmosis merged commit 647ed54 into 4.x-dev Apr 21, 2021
@diosmosis diosmosis deleted the 17301-remove-urlencode-from-segment branch April 21, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Store the segment hash in the DB table
4 participants