Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use rawSafeDecoded filter #17473

Merged
merged 1 commit into from Apr 19, 2021
Merged

use rawSafeDecoded filter #17473

merged 1 commit into from Apr 19, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Apr 19, 2021

Description:

Use rawSafeDecoded instead of raw twig filter

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Apr 19, 2021
@flamisz flamisz added this to the 4.3.0 milestone Apr 19, 2021
@flamisz flamisz added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 19, 2021
@sgiehl sgiehl merged commit f1b82cd into 4.x-dev Apr 19, 2021
@sgiehl sgiehl deleted the use-raw-safe-decoded-filter branch April 19, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants