Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add query string to error logs #17472

Merged
merged 5 commits into from Jun 28, 2021
Merged

Add query string to error logs #17472

merged 5 commits into from Jun 28, 2021

Conversation

diosmosis
Copy link
Member

Description:

As title. Noticed a lot of these in the logs, but there's not enough information to see where they came from.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 19, 2021
@sgiehl
Copy link
Member

sgiehl commented Apr 19, 2021

Did you suppose to changes this visible exception message: https://builds-artifacts.matomo.org/matomo-org/matomo/not-yet-installed-better-message/46346/Installation_access_no_config.png

@sgiehl sgiehl removed the Needs Review PRs that need a code review label Apr 22, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @tsteur @sgiehl @diosmosis @flamisz

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Jun 4, 2021
@sgiehl
Copy link
Member

sgiehl commented Jun 8, 2021

@diosmosis there are still some failing tests

@sgiehl sgiehl removed the Stale for long The label used by the Close Stale Issues action label Jun 8, 2021
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jun 24, 2021
@diosmosis diosmosis added the Do not close PRs with this label won't be marked as stale by the Close Stale Issues action label Jun 27, 2021
@diosmosis
Copy link
Member Author

@sgiehl do you have any issue with merging this?

@github-actions github-actions bot removed the Stale The label used by the Close Stale Issues action label Jun 28, 2021
@sgiehl
Copy link
Member

sgiehl commented Jun 28, 2021

Seems tests are passing now. So feel free to merge

@diosmosis diosmosis merged commit c3337d2 into 4.x-dev Jun 28, 2021
@diosmosis diosmosis deleted the not-yet-installed-better-message branch June 28, 2021 19:53
@mattab mattab changed the title Add some context to this error since logs will not have the host or instance or other information. Add query string to error since logs Jul 27, 2021
@mattab mattab changed the title Add query string to error since logs Add query string to error logs Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@diosmosis @sgiehl