@diosmosis opened this Pull Request on April 19th 2021 Member

Description:

As title. Noticed a lot of these in the logs, but there's not enough information to see where they came from.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@sgiehl commented on April 19th 2021 Member
@github-actions[bot] commented on June 4th 2021 Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @tsteur @sgiehl @diosmosis @flamisz

@sgiehl commented on June 8th 2021 Member

@diosmosis there are still some failing tests

@github-actions[bot] commented on June 24th 2021 Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@diosmosis commented on June 27th 2021 Member

@sgiehl do you have any issue with merging this?

@sgiehl commented on June 28th 2021 Member

Seems tests are passing now. So feel free to merge

This Pull Request was closed on June 28th 2021
Powered by GitHub Issue Mirror