Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow goals being triggered when a visitor visits a certain number of pages #17466

Open
wants to merge 4 commits into
base: 4.x-dev
Choose a base branch
from
Open

Allow goals being triggered when a visitor visits a certain number of pages #17466

wants to merge 4 commits into from

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 16, 2021

Description:

fixes #2029

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

sgiehl
sgiehl commented Apr 16, 2021
View reviewed changes
core/Tracker/GoalManager.php Outdated Show resolved Hide resolved
@sgiehl sgiehl marked this pull request as ready for review April 16, 2021 13:14
@sgiehl sgiehl added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 16, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Apr 16, 2021
@sgiehl sgiehl force-pushed the pageviewgoal branch 2 times, most recently from 2a1533d to ef6cb73 Compare April 22, 2021 14:56
@sgiehl sgiehl modified the milestones: 4.3.0, 5.0.0 May 3, 2021
@sgiehl sgiehl force-pushed the pageviewgoal branch 2 times, most recently from b7eeb2e to f3c771c Compare May 6, 2021 13:38
@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2021

This issue is in "needs review" but there has been no activity for 7 days. ping @tsteur @sgiehl @diosmosis @flamisz

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jun 4, 2021
@sgiehl sgiehl added Do not close PRs with this label won't be marked as stale by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jun 8, 2021
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @tsteur @sgiehl @diosmosis @flamisz

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jun 16, 2021
@github-actions
Copy link
Contributor

This issue is in "needs review" but there has been no activity for 7 days. ping @tsteur @justinvelluppillai @sgiehl @diosmosis

@github-actions github-actions bot added Stale The label used by the Close Stale Issues action and removed Stale The label used by the Close Stale Issues action labels Jun 24, 2021
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Jun 24, 2021
@sgiehl sgiehl mentioned this pull request Jul 8, 2022
Open
@tsteur tsteur modified the milestones: 5.0.0, 6.0.0 Jul 11, 2022
@tsteur tsteur modified the milestones: 6.0.0, 5.0.0 Jul 11, 2022
@tsteur tsteur modified the milestones: 5.0.0, 6.0.0 Jul 18, 2022
@sgiehl sgiehl mentioned this pull request Oct 10, 2022
Open
@sgiehl sgiehl mentioned this pull request Dec 19, 2022
Merged
11 tasks
@sgiehl sgiehl mentioned this pull request Mar 29, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis left review comments

@tsteur tsteur tsteur left review comments

@mattab mattab mattab left review comments

Assignees
No one assigned
Labels
Do not close PRs with this label won't be marked as stale by the Close Stale Issues action not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
6.0.0
4 participants
@sgiehl @diosmosis @tsteur @mattab