Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow generating reports in TSV format #17464

Merged
merged 2 commits into from Apr 16, 2021
Merged

Allow generating reports in TSV format #17464

merged 2 commits into from Apr 16, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 15, 2021

Description:

This PR will make it possible to send scheduled reports in TSV format.

Note: Did those changes in a couple of minutes only. Will try to complete the PR when I have some time in between maybe.

fixes #17463

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. label Apr 15, 2021
@sgiehl sgiehl self-assigned this Apr 15, 2021
@sgiehl sgiehl marked this pull request as ready for review April 15, 2021 11:27
@sgiehl sgiehl added Needs Review PRs that need a code review and removed Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. labels Apr 15, 2021
@sgiehl sgiehl removed their assignment Apr 15, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Apr 16, 2021
@diosmosis diosmosis added the not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. label Apr 16, 2021
@diosmosis
Copy link
Member

Works for me and tests pass, merging

@diosmosis diosmosis merged commit affd373 into 4.x-dev Apr 16, 2021
@diosmosis diosmosis deleted the tsvreports branch April 16, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Email export as TSV format
2 participants
@sgiehl @diosmosis