New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add testdox to phpunit.xml #17462
Add testdox to phpunit.xml #17462
Conversation
Personally I wouldn't enable that by default in |
In my case was different, I wanted to know where it failed on Travis because failed differently, but anytime we can just commit it when needed (probably or hopefully very rare) and when we fixed it, modify it back. This is what I did. I just wanted to know the team thinks about it :) |
Personally finding it quite useful because it'll be there when you need it, and doesn't really cause too much harm when it's not needed. For me it loads as fast, the scrolling to the end takes a second though but that's it. Finding it also quite good to see how long each test took etc. The timings are not ongoing information you need every time though. Other people might not know how and where to set this flag when tests are not executing so it working instantly could be quite good. Especially also for community contributors etc. Luckily, we don't really have much problems anymore with builds timing out otherwise it would have been useful. I can also see though that it does add noise and we could enable it on demand but then ideally there be some output in travis run like this (could even include a link to an FAQ where we explain how to do it) @diosmosis any thoughts? |
Not really, either way is fine for me. |
@tsteur I don't think that "trigger another test run by doing...". if you modify the And for me it wasn't an issue either, the result was longer on travis. |
@tsteur @sgiehl @diosmosis |
@flamisz @sgiehl @diosmosis I would say let's just merge it and disable it again (and then instead print a message on how to activate this feature to troubleshoot when needed) should we find it not useful. Be good to simply give it a try for a while and if we find it a problem then change. In UI tests we've always been doing this and it never was an issue. @sgiehl @diosmosis @flamisz be important to mention if/when it becomes annoying (eg with heaps of other test failures or so) and then we change it again. Be also useful if it ever helps you to mention eg in slack channel or so "Hey this just helped me save time or find xyz". |
It makes sense to try it first. |
Let's simply merge then. We can later remove again if it might get annoying |
Description:
I had a failing test in another PR and it was hard to understand why and where it is happening. Modifying the
phpunit.xml
can help investigate failing tests easier.Instead of only dots, we have some information about what's going on, and if a build fails, we can see which one was the last test.
An example:
Review