Add get-segment-sql development command for debugging #17461
Conversation
plugins/SitesManager/Model.php
Outdated
| @@ -240,7 +240,7 @@ public function getSiteFromId($idSite) | |||
| * Returns the list of all the website IDs registered. | |||
| * Caller must check access. | |||
| * | |||
| * @return array The list of website IDs | |||
| * @return int[] The list of website IDs | |||
There was a problem hiding this comment.
That actually might not be correct. Depending on the mysql configuration it might be an array of strings. But guess we could add a cast to int in the foreach to ensure only ints are returned
There was a problem hiding this comment.
I could do int[]|string[]. As long as it's not array, it'll be more useful.
There was a problem hiding this comment.
Sure. no preference. Just wanted to mention that the return type can vary. Maybe casting to int would be even better, so we can rely on the return type?
There was a problem hiding this comment.
Might be more useful, but given we don't do that for any other query in Matomo (that I know of), I'm not sure it's really needed (and might make things more inconsistent).
There was a problem hiding this comment.
Feel free to change the doc block only then. Having more strict return types is a more global thing for sure 🙈
|
@flamisz segments are converted into SQL to select visits in Matomo, but for many segments the SQL is complicated and hard to imagine in your head (or mine at least), so the command prints it out so you can see how it's converted from a segment string (ie, |
Description:
Prints out the query of a segment, can be used if trying to determine if a segment is query is being built correctly or not.
Review