Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website Measurables can be created with no URLs which breaks some features #17459

Open
diosmosis opened this issue Apr 15, 2021 · 0 comments
Open
Labels
Bug For errors / faults / flaws / inconsistencies etc.

Comments

@diosmosis
Copy link
Member

When creating a website measurable, we want to make sure at least one URL is always defined. However, since site URLs can be specified by plugin setting, it's possible to omit the 'urls' plugin setting entirely, or just send the name, eg, ['name' => 'urls'] instead of ['name' => 'urls', 'values' => ...]. In these cases, Matomo just ignores the setting entirely, never checking it or setting it to anything.

Having no site URL causes features like Overlay to break, so we should require them. However, some measurables legitimately have no URLs (like RollUps).

@diosmosis diosmosis added the Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. label Apr 15, 2021
@diosmosis diosmosis added this to the 5.0.0 milestone Apr 15, 2021
@diosmosis diosmosis added Bug For errors / faults / flaws / inconsistencies etc. and removed Potential Bug Something that might be a bug, but needs validation and confirmation it can be reproduced. labels Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants