Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show period label on evo graph #17456

Merged
merged 7 commits into from Apr 21, 2021
Merged

show period label on evo graph #17456

merged 7 commits into from Apr 21, 2021

Conversation

flamisz
Copy link
Contributor

@flamisz flamisz commented Apr 14, 2021

Description:

fixes #15021

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@flamisz flamisz self-assigned this Apr 14, 2021
@flamisz flamisz added Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. labels Apr 14, 2021
@flamisz
Copy link
Contributor Author

flamisz commented Apr 14, 2021

sneak peak

Screen.Recording.2021-04-14.at.3.50.52.PM.mov

@flamisz flamisz added this to the 4.3.0 milestone Apr 14, 2021
@flamisz
Copy link
Contributor Author

flamisz commented Apr 16, 2021

@mattab can you please check it and if it's ok, I will update the UI tests. Thanks

@mattab
Copy link
Member

mattab commented Apr 19, 2021

@flamisz it looks great! 👍

One feedback, would it be possible on click, to show directly the clicked label?

  • Got it shows "Day", you click on "week" but it still shows "Day" until it's loaded
  • Expected it shows "Day", you click on "week" and it still shows "Week" until it's loaded

@flamisz
Copy link
Contributor Author

flamisz commented Apr 19, 2021

@flamisz it looks great! 👍

One feedback, would it be possible on click, to show directly the clicked label?

* Got it shows "Day", you click on "week" but it still shows "Day" until it's loaded

* Expected it shows "Day", you click on "week" and it still shows "Week" until it's loaded

good catch 👍 , I'll do that

@flamisz
Copy link
Contributor Author

flamisz commented Apr 20, 2021

@mattab I updated the workflow, now the text is changing when the user selects a new value, not just after the reload.

Screen.Recording.2021-04-20.at.3.38.08.PM.mov

@mattab
Copy link
Member

mattab commented Apr 20, 2021

Looks good to me @flamisz - a smooth experience!

sgiehl
sgiehl requested changes Apr 20, 2021
View reviewed changes
plugins/CoreHome/templates/_dataTableActions.twig Outdated Show resolved Hide resolved
plugins/CoreHome/javascripts/dataTable.js Outdated Show resolved Hide resolved
sgiehl
sgiehl approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@sgiehl sgiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I've updated the branch. Should be good to merge if all tests are passing

@flamisz flamisz merged commit b66635e into 4.x-dev Apr 21, 2021
@flamisz flamisz deleted the 15021-period-label-on-evo-graph branch April 21, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgiehl sgiehl sgiehl approved these changes

Assignees

@flamisz flamisz

Labels
Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Show periods labels in the evolution graphs to make it easier to change period
3 participants
@flamisz @mattab @sgiehl