@flamisz opened this Pull Request on April 14th 2021 Contributor

Description:

fixes #15021

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@flamisz commented on April 14th 2021 Contributor
@flamisz commented on April 16th 2021 Contributor

@mattab can you please check it and if it's ok, I will update the UI tests. Thanks

@mattab commented on April 19th 2021 Member

@flamisz it looks great! :+1:

One feedback, would it be possible on click, to show directly the clicked label?

  • Got it shows "Day", you click on "week" but it still shows "Day" until it's loaded
  • Expected it shows "Day", you click on "week" and it still shows "Week" until it's loaded
@flamisz commented on April 19th 2021 Contributor

@flamisz it looks great! 👍

One feedback, would it be possible on click, to show directly the clicked label?

* Got it shows "Day", you click on "week" but it still shows "Day" until it's loaded

* Expected it shows "Day", you click on "week" and it still shows "Week" until it's loaded

good catch 👍 , I'll do that

@flamisz commented on April 20th 2021 Contributor

@mattab I updated the workflow, now the text is changing when the user selects a new value, not just after the reload.

https://user-images.githubusercontent.com/6749509/115333928-9b9d5580-a1ee-11eb-925c-242c21811b18.mov

@mattab commented on April 20th 2021 Member

Looks good to me @flamisz - a smooth experience!

This Pull Request was closed on April 21st 2021
Powered by GitHub Issue Mirror