Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INI process_new_segments_from: allow processing segments X days before last edit day #17447

Merged
merged 1 commit into from Apr 12, 2021
Merged

INI process_new_segments_from: allow processing segments X days before last edit day #17447

merged 1 commit into from Apr 12, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 12, 2021

Description:

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added the Needs Review PRs that need a code review label Apr 12, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Apr 12, 2021
@tsteur
Copy link
Member

tsteur commented Apr 12, 2021

haven't tested it but looks good 👍

@diosmosis
Copy link
Member

Tested locally, works for me

@diosmosis diosmosis merged commit 52d63e5 into 4.x-dev Apr 12, 2021
@diosmosis diosmosis deleted the l3-63 branch April 12, 2021 23:26
@mattab mattab changed the title Allow processing segments X days before last edit day INI process_new_segments_from: allow processing segments X days before last edit day May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Needs Review PRs that need a code review
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sgiehl @tsteur @diosmosis