Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont load unneeded images #17446

Merged
merged 2 commits into from Apr 12, 2021
Merged

Dont load unneeded images #17446

merged 2 commits into from Apr 12, 2021

Conversation

Findus23
Copy link
Member

fixes #17422

Lacking a better workaround this should also fix the issue.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@Findus23 Findus23 added the Needs Review PRs that need a code review label Apr 12, 2021
@diosmosis diosmosis added this to the 4.3.0 milestone Apr 12, 2021
@diosmosis diosmosis added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Apr 12, 2021
@diosmosis diosmosis merged commit 3c0c8c6 into 4.x-dev Apr 12, 2021
@diosmosis diosmosis deleted the dont-load-unneeded-images branch April 12, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

Don't load review logos if they are not shown
2 participants
@Findus23 @diosmosis