@sgiehl opened this Pull Request on April 12th 2021 Member

Description:

While testing I recognized, that when an access exception is thrown Matomo currently always shows a "session expired" error, even though the user might still be logged in, but simply does not have access for the current site.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on April 12th 2021 Member

Tested locally, works for me. Is it possible to get this tested?

@sgiehl commented on April 13th 2021 Member

@diosmosis added some UI tests for it

This Pull Request was closed on April 14th 2021
Powered by GitHub Issue Mirror