Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate segment data on update only if the definition changes #17444

Closed
tsteur opened this issue Apr 12, 2021 · 0 comments · Fixed by #17458
Closed

Invalidate segment data on update only if the definition changes #17444

tsteur opened this issue Apr 12, 2021 · 0 comments · Fixed by #17458
Assignees
@sgiehl
Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
4.3.0

Comments

@tsteur
Copy link
Member

tsteur commented Apr 12, 2021

In https://github.com/matomo-org/matomo/blob/4.3.0-b2/plugins/SegmentEditor/API.php#L278 we trigger to rearchive the segment whenever it is updated. However, we should only do this if the definition changes (because the meaning of the report changes) or if the autoArchive changes from false/0 to true/1 (because then we'd want to make sure to have all the needed reports for in the past depending on configured setting).

This will be useful as this way we don't invalidate and rearchive reports unnecessarily.
@tsteur tsteur added Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. labels Apr 12, 2021
@tsteur tsteur added this to the 4.3.0 milestone Apr 12, 2021
@sgiehl sgiehl self-assigned this Apr 14, 2021
@sgiehl sgiehl mentioned this issue Apr 14, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Help wanted Beginner friendly issues or issues where we'd highly appreciate community's help and involvement. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging a pull request may close this issue.

Rearchive segment only when definition changed matomo-org/matomo
2 participants
@tsteur @sgiehl