@diosmosis opened this Pull Request on April 9th 2021 Member

Description:

Now in DbHelper::getTablesInstalled() we post an event and force load all activated plugins: https://github.com/matomo-org/matomo/blob/4.x-dev/core/Db/Schema/Mysql.php#L453-L458

This is quite a bit more work, it seems. Locally it slows each individual integration test case by about 14s. Removing it speeds the LoaderTest, for example, from 10mins to finish to 1min.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on April 9th 2021 Member

@sgiehl updated.

This Pull Request was closed on April 11th 2021
Powered by GitHub Issue Mirror