Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up integration tests by not using DbHelper::getTablesInstalled() #17440

Merged
merged 2 commits into from Apr 11, 2021

Conversation

diosmosis
Copy link
Member

Description:

Now in DbHelper::getTablesInstalled() we post an event and force load all activated plugins: https://github.com/matomo-org/matomo/blob/4.x-dev/core/Db/Schema/Mysql.php#L453-L458

This is quite a bit more work, it seems. Locally it slows each individual integration test case by about 14s. Removing it speeds the LoaderTest, for example, from 10mins to finish to 1min.

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@diosmosis diosmosis added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review labels Apr 9, 2021
@sgiehl sgiehl removed the Needs Review PRs that need a code review label Apr 9, 2021
@diosmosis diosmosis added the Needs Review PRs that need a code review label Apr 9, 2021
@diosmosis
Copy link
Member Author

@sgiehl updated.

@sgiehl sgiehl added not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. and removed Needs Review PRs that need a code review labels Apr 11, 2021
@sgiehl sgiehl merged commit d76d7e2 into 4.x-dev Apr 11, 2021
@sgiehl sgiehl deleted the integration-test-perf branch April 11, 2021 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants