Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape URL in geolocation admin error message #17436

Merged
merged 2 commits into from Apr 8, 2021
Merged

Escape URL in geolocation admin error message #17436

merged 2 commits into from Apr 8, 2021

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Apr 8, 2021

Description:

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@sgiehl sgiehl added c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github. Needs Review PRs that need a code review labels Apr 8, 2021
@sgiehl sgiehl added this to the 4.3.0 milestone Apr 8, 2021
@sgiehl sgiehl requested a review from diosmosis April 8, 2021 13:44
@diosmosis diosmosis removed the Needs Review PRs that need a code review label Apr 8, 2021
diosmosis
diosmosis requested changes Apr 8, 2021
View reviewed changes
Copy link
Member

@diosmosis diosmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a comment

@diosmosis diosmosis merged commit f6d683a into 4.x-dev Apr 8, 2021
@diosmosis diosmosis deleted the geoipsec branch April 8, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diosmosis diosmosis diosmosis requested changes

Assignees
No one assigned
Labels
c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github.
Projects
None yet
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @diosmosis