@flamisz opened this Pull Request on April 8th 2021 Contributor

Description:

This new class will check if the validated field only contains alphanumeric characters and spaces. No special characters allowed.

Review

  • [ ] Functional review done
  • [ ] Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • [ ] Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • [ ] Security review done see checklist
  • [ ] Code review done
  • [ ] Tests were added if useful/possible
  • [ ] Reviewed for breaking changes
  • [ ] Developer changelog updated if needed
  • [ ] Documentation added if needed
  • [ ] Existing documentation updated if needed
@diosmosis commented on April 8th 2021 Member

I think we have unit tests for existing validators so we'd want to add one for this.

Powered by GitHub Issue Mirror